<html>
<head><meta charset="utf-8"><title>Updating clippy to account for a stabilization · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Updating.20clippy.20to.20account.20for.20a.20stabilization.html">Updating clippy to account for a stabilization</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="207895387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Updating%20clippy%20to%20account%20for%20a%20stabilization/near/207895387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Updating.20clippy.20to.20account.20for.20a.20stabilization.html#207895387">(Aug 24 2020 at 20:45)</a>:</h4>
<p>My stabilization PR for <code>Range::is_empty</code> (<a href="https://github.com/rust-lang/rust/pull/75132">https://github.com/rust-lang/rust/pull/75132</a>) is failing on the clippy test <code>len_zero_ranges</code> from <a href="https://github.com/rust-lang/rust-clippy/pull/5656/files">https://github.com/rust-lang/rust-clippy/pull/5656/files</a></p>
<p>What do I need to do to check this in in a non-breaking way?  Do I undo that change in clippy, then update clippy as part of my stabilization PR?  Or do I just wait for after the beta branch and I'll be allowed to break clippy tests once it's not the last week of the 6-week cycle?</p>



<a name="207896604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Updating%20clippy%20to%20account%20for%20a%20stabilization/near/207896604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Updating.20clippy.20to.20account.20for.20a.20stabilization.html#207896604">(Aug 24 2020 at 20:57)</a>:</h4>
<p>clippy is kinda part of the rustc repo now as a subrepo</p>



<a name="207896695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Updating%20clippy%20to%20account%20for%20a%20stabilization/near/207896695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Updating.20clippy.20to.20account.20for.20a.20stabilization.html#207896695">(Aug 24 2020 at 20:58)</a>:</h4>
<p>you can fix the clippy test as part of your pr and the change will be merged into the upstream clippy repo eventually</p>



<a name="207896766"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Updating%20clippy%20to%20account%20for%20a%20stabilization/near/207896766" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Updating.20clippy.20to.20account.20for.20a.20stabilization.html#207896766">(Aug 24 2020 at 20:58)</a>:</h4>
<p>(syncs from rustc -&gt; clippy upstream are usually done every few days; if something breaks the build of the clippy repo<br>
syncs from clippy-upstream -&gt; rustc repo are done every 2 weeks afaik)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>